Re: [PATCH v3 1/3] Add tests for describe with --work-tree

2019-01-30 Thread Jeff King
On Wed, Jan 30, 2019 at 11:23:14AM +0100, Sebastian Staudt wrote: > > >> +grep 'A-\d\+-g[0-9a-f]\+' '$TRASH_DIRECTORY/out' > > > > > > Using "\d" isn't portable. > > > > True, but not just \d. I think using \ before special characters to > > force an otherwise basic regular expression to be E

Re: [PATCH v3 1/3] Add tests for describe with --work-tree

2019-01-30 Thread Sebastian Staudt
Am Di., 29. Jan. 2019 um 18:47 Uhr schrieb Junio C Hamano : > > Jeff King writes: > > > The usual style is to put the whole snippet into single-quotes, and then > > double-quote as appropriate within it. Like: > > > > test_expect_failure 'describe --dirty with --work-tree' ' > > ( > >

Re: [PATCH v3 1/3] Add tests for describe with --work-tree

2019-01-29 Thread Junio C Hamano
Jeff King writes: > The usual style is to put the whole snippet into single-quotes, and then > double-quote as appropriate within it. Like: > > test_expect_failure 'describe --dirty with --work-tree' ' > ( > cd "$TEST_DIRECTORY" && > git --git-dir "$TRASH_DIREC

Re: [PATCH v3 1/3] Add tests for describe with --work-tree

2019-01-29 Thread Jeff King
On Tue, Jan 29, 2019 at 06:18:57AM +0100, Sebastian Staudt wrote: > The dirty ones are already passing, but just because describe is comparing > with the wrong working tree. > > Signed-off-by: Sebastian Staudt > --- > t/t6120-describe.sh | 33 + > 1 file changed,

[PATCH v3 1/3] Add tests for describe with --work-tree

2019-01-28 Thread Sebastian Staudt
The dirty ones are already passing, but just because describe is comparing with the wrong working tree. Signed-off-by: Sebastian Staudt --- t/t6120-describe.sh | 33 + 1 file changed, 33 insertions(+) diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh index d