Re: [PATCH v3 1/2] alloc.c: remove the alloc_raw_commit_node() function

2014-07-10 Thread Ramsay Jones
On 11/07/14 01:09, Jeff King wrote: > On Fri, Jul 11, 2014 at 12:58:31AM +0100, Ramsay Jones wrote: > >> #define DEFINE_ALLOCATOR(name, type)\ >> -static unsigned int name##_allocs; \ >> +static struct alloc_state name##_state;

Re: [PATCH v3 1/2] alloc.c: remove the alloc_raw_commit_node() function

2014-07-10 Thread Jeff King
On Fri, Jul 11, 2014 at 12:58:31AM +0100, Ramsay Jones wrote: > #define DEFINE_ALLOCATOR(name, type) \ > -static unsigned int name##_allocs; \ > +static struct alloc_state name##_state; \ > void *alloc_##name##_node(v

[PATCH v3 1/2] alloc.c: remove the alloc_raw_commit_node() function

2014-07-10 Thread Ramsay Jones
In order to encapsulate the setting of the unique commit index, commit 969eba63 ("commit: push commit_index update into alloc_commit_node", 10-06-2014) introduced a (logically private) intermediary allocator function. However, this function (alloc_raw_commit_node()) was declared as a public functi