Re: [PATCH v3 1/1] abspath_part_inside_repo: respect core.fileMode

2019-01-18 Thread Johannes Schindelin
Hi Junio, first of all, my apologies for the incorrect commit message (you missed it, too, though): it is not about respecting core.fileMode, but about core.ignoreCase. On Tue, 25 Dec 2018, Junio C Hamano wrote: > Junio C Hamano writes: > > > the resulting index entry is "blub" or "BLUB". Sho

Re: [PATCH v3 1/1] abspath_part_inside_repo: respect core.fileMode

2018-12-25 Thread Junio C Hamano
Junio C Hamano writes: > the resulting index entry is "blub" or "BLUB". Shouldn't we verify > that "git add" adds an expected path to the index, instead of > blindly trusting that it says "Yeah, I did as I was told" with its > exit status? Would we be adding 'blub' as that is what we told > 'gi

Re: [PATCH v3 1/1] abspath_part_inside_repo: respect core.fileMode

2018-12-24 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > diff --git a/setup.c b/setup.c > index 1be5037f12..291bfb2128 100644 > --- a/setup.c > +++ b/setup.c > @@ -39,7 +39,7 @@ static int abspath_part_inside_repo(char *path) > off = offset_1st_component(path); > > /* check if work tree is

[PATCH v3 1/1] abspath_part_inside_repo: respect core.fileMode

2018-12-24 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin If the file system is case-insensitive, we really must be careful to ignore differences in case only. This fixes https://github.com/git-for-windows/git/issues/735 Signed-off-by: Johannes Schindelin --- setup.c| 6 +++--- t/t3700-add.sh | 7 +++ 2 files ch