Re: [PATCH v3 1/1] Makefile: make curl-config path configurable

2015-10-05 Thread Remi Pommarel
On Mon, Oct 05, 2015 at 02:11:07PM -0700, Jonathan Nieder wrote: > Remi Pommarel wrote: > > > Do I need to resend a v4 patch with these modifications ? I am not sure > > about the correct workflow here. > > If you like the changes, you can ask Junio to squash them in. > > If you don't like them,

Re: [PATCH v3 1/1] Makefile: make curl-config path configurable

2015-10-05 Thread Jonathan Nieder
Remi Pommarel wrote: > Do I need to resend a v4 patch with these modifications ? I am not sure > about the correct workflow here. If you like the changes, you can ask Junio to squash them in. If you don't like them, that's also fine and you can just say so. -- To unsubscribe from this list: send

Re: [PATCH v3 1/1] Makefile: make curl-config path configurable

2015-10-05 Thread Remi Pommarel
On Mon, Oct 05, 2015 at 01:49:09PM -0700, Jonathan Nieder wrote: > Remi Pommarel wrote: > > > Signed-off-by: Remi Pommarel > > For what it's worth, with or without the tweaks below, > > Reviewed-by: Jonathan Nieder Thanks. > > [...] > > --- a/Makefile > > +++ b/Makefile > > @@ -39,6 +39,10

Re: [PATCH v3 1/1] Makefile: make curl-config path configurable

2015-10-05 Thread Jonathan Nieder
Remi Pommarel wrote: > Signed-off-by: Remi Pommarel For what it's worth, with or without the tweaks below, Reviewed-by: Jonathan Nieder [...] > --- a/Makefile > +++ b/Makefile > @@ -39,6 +39,10 @@ all:: > # Define CURLDIR=/foo/bar if your curl header and library files are in > # /foo/bar/in

[PATCH v3 1/1] Makefile: make curl-config path configurable

2015-10-05 Thread Remi Pommarel
There are situations, e.g. during cross compilation, where curl-config program is not present in the PATH. Make the makefile use a configurable curl-config program passed through CURL_CONFIG variable which can be set through config.mak. Also make this variable tunable through use of autoconf/conf