Re: [PATCH v3 1/1] Makefile: link libcurl before libssl

2015-10-21 Thread Junio C Hamano
Remi Pommarel writes: > On Tue, Oct 20, 2015 at 01:20:18PM -0700, Junio C Hamano wrote: >> >> So, what's the status of this patch and other two patches (I >> consider them as a three-patch series)? > > So I have to fix the non initialized variable and to rephrase a litle > bit the description fo

Re: [PATCH v3 1/1] Makefile: link libcurl before libssl

2015-10-21 Thread Remi Pommarel
On Tue, Oct 20, 2015 at 01:20:18PM -0700, Junio C Hamano wrote: > Remi Pommarel writes: > > > On Mon, Oct 05, 2015 at 12:41:34PM -0700, Jonathan Nieder wrote: > > ... > >> To protect against a value that might leak in from the environment, this > >> should say > >> > >>IMAP_SEND_LDFLAGS = >

Re: [PATCH v3 1/1] Makefile: link libcurl before libssl

2015-10-20 Thread Junio C Hamano
Remi Pommarel writes: > On Mon, Oct 05, 2015 at 12:41:34PM -0700, Jonathan Nieder wrote: > ... >> To protect against a value that might leak in from the environment, this >> should say >> >> IMAP_SEND_LDFLAGS = >> >> [...] > > Oups my bad. > ... So, what's the status of this patch and oth

Re: [PATCH v3 1/1] Makefile: link libcurl before libssl

2015-10-05 Thread Remi Pommarel
On Mon, Oct 05, 2015 at 12:41:34PM -0700, Jonathan Nieder wrote: > Remi Pommarel wrote: [...] > Based on this dependency, shouldn't CURL_LIBCURL always include -lssl when > statically linking? How does this relate to NEEDS_SSL_WITH_CURL? In fact libcurl will only need -lssl when the curl librar

Re: [PATCH v3 1/1] Makefile: link libcurl before libssl

2015-10-05 Thread Jonathan Nieder
Remi Pommarel wrote: > For static linking especially library order while linking is important. For Please be more explicit for the uninitiated: during static linking, the library that needs symbols comes before the library providing those symbols. > example, libcurl wants symbols for libssl when

[PATCH v3 1/1] Makefile: link libcurl before libssl

2015-10-05 Thread Remi Pommarel
For static linking especially library order while linking is important. For example, libcurl wants symbols for libssl when building http-push, http-fetch and remote-curl. So for these programs libcurl has to be linked before libssl. Signed-off-by: Remi Pommarel --- Makefile | 8 1 file