Re: [PATCH v3 09/10] submodule--helper init: set submodule..active

2017-03-16 Thread Junio C Hamano
Brandon Williams writes: > So if we did > > git clone --submodule-spec=lib/ > > then each module under 'lib/' won't have their submodule..active > config set since submodule.active=lib/ already encompasses them. Ah, OK. That removes my worries ;-) Thanks for an explanation.

Re: [PATCH v3 09/10] submodule--helper init: set submodule..active

2017-03-15 Thread Brandon Williams
On 03/14, Junio C Hamano wrote: > Brandon Williams writes: > > > When initializing a submodule set the submodule..active config to > > true to indicate that the submodule is active. > > > > Signed-off-by: Brandon Williams > > --- > > Hmph. When you do > > git clone --submodule-spec=lib/

Re: [PATCH v3 09/10] submodule--helper init: set submodule..active

2017-03-14 Thread Junio C Hamano
Brandon Williams writes: > When initializing a submodule set the submodule..active config to > true to indicate that the submodule is active. > > Signed-off-by: Brandon Williams > --- Hmph. When you do git clone --submodule-spec=lib/ and resulting repository says "submodule.active =

[PATCH v3 09/10] submodule--helper init: set submodule..active

2017-03-13 Thread Brandon Williams
When initializing a submodule set the submodule..active config to true to indicate that the submodule is active. Signed-off-by: Brandon Williams --- builtin/submodule--helper.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c in