Re: [PATCH v3 08/10] remote-hg: update bookmarks when pulling

2013-05-14 Thread Felipe Contreras
On Tue, May 14, 2013 at 6:32 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> ... After all, this is in the contrib area, >> so if there's a time for a possible future maintainer of a core part >> of git to make mistakes, it would be now. > > That sounds reasonable. > > Incidentally, bef

Re: [PATCH v3 08/10] remote-hg: update bookmarks when pulling

2013-05-14 Thread Junio C Hamano
Felipe Contreras writes: > ... After all, this is in the contrib area, > so if there's a time for a possible future maintainer of a core part > of git to make mistakes, it would be now. That sounds reasonable. Incidentally, before I had to stop working in order to respond to your endless argume

Re: [PATCH v3 08/10] remote-hg: update bookmarks when pulling

2013-05-14 Thread Felipe Contreras
On Tue, May 14, 2013 at 5:49 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> The reason for the "only regression" period is to avoid more >> regressions. If you show me how any of the fixes I sent in this series >> could potentially cause a regression, > > I already said that "You can s

Re: [PATCH v3 08/10] remote-hg: update bookmarks when pulling

2013-05-14 Thread Junio C Hamano
Felipe Contreras writes: > The reason for the "only regression" period is to avoid more > regressions. If you show me how any of the fixes I sent in this series > could potentially cause a regression, I already said that "You can see these patches are so trivially correct" is not a valid argumen

Re: [PATCH v3 08/10] remote-hg: update bookmarks when pulling

2013-05-14 Thread Felipe Contreras
On Tue, May 14, 2013 at 5:25 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> On Tue, May 14, 2013 at 4:59 PM, Junio C Hamano wrote: >>> Felipe Contreras writes: >>> Without this fix, the user would never ever see new bookmarks, only the ones that (s)he initially cloned

Re: [PATCH v3 08/10] remote-hg: update bookmarks when pulling

2013-05-14 Thread Junio C Hamano
Felipe Contreras writes: > On Tue, May 14, 2013 at 4:59 PM, Junio C Hamano wrote: >> Felipe Contreras writes: >> >>> Without this fix, the user would never ever see new bookmarks, only the ones >>> that (s)he initially cloned. >> >> Now, think again and realize how long it took you (the origina

Re: [PATCH v3 08/10] remote-hg: update bookmarks when pulling

2013-05-14 Thread Felipe Contreras
On Tue, May 14, 2013 at 4:59 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> Without this fix, the user would never ever see new bookmarks, only the ones >> that (s)he initially cloned. > > Now, think again and realize how long it took you (the original > author) to discover issues and

Re: [PATCH v3 08/10] remote-hg: update bookmarks when pulling

2013-05-14 Thread Junio C Hamano
Felipe Contreras writes: > Without this fix, the user would never ever see new bookmarks, only the ones > that (s)he initially cloned. Now, think again and realize how long it took you (the original author) to discover issues and come up with these fixes and explanation since the series was merg

RE: [PATCH v3 08/10] remote-hg: update bookmarks when pulling

2013-05-14 Thread Felipe Contreras
Without this fix, the user would never ever see new bookmarks, only the ones that (s)he initially cloned. Felipe Contreras wrote: > Signed-off-by: Felipe Contreras > --- > contrib/remote-helpers/git-remote-hg | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/contrib/remote-helpers/git

[PATCH v3 08/10] remote-hg: update bookmarks when pulling

2013-05-13 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- contrib/remote-helpers/git-remote-hg | 3 +++ 1 file changed, 3 insertions(+) diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg index beb864b..dc276af 100755 --- a/contrib/remote-helpers/git-remote-hg +++ b/contrib/remot