Re: [PATCH v3 07/19] refs.c: remove the onerr argument to ref_transaction_commit

Thanks. Reworded it that we remove it since all callers now use QUIET_ON_ERR On Fri, Apr 25, 2014 at 3:47 PM, Jonathan Nieder wrote: > Ronnie Sahlberg wrote: > >> Since we now pass meaningful error messages back from ref_transaction_commit >> on failures, we no longer need to provide a onerr arg

Re: [PATCH v3 07/19] refs.c: remove the onerr argument to ref_transaction_commit

Ronnie Sahlberg wrote: > Since we now pass meaningful error messages back from ref_transaction_commit > on failures, we no longer need to provide a onerr argument. Yay! More precisely, now that all callers use UPDATE_REFS_QUIET_ON_ERR there's no need to support any other behavior. Thanks for cl

[PATCH v3 07/19] refs.c: remove the onerr argument to ref_transaction_commit

Since we now pass meaningful error messages back from ref_transaction_commit on failures, we no longer need to provide a onerr argument. The callers can now on commit failures die() with a meaningful, and in most cases even better than before, error message. Signed-off-by: Ronnie Sahlberg --- bu