Re: [PATCH v3 06/11] diff: rename struct diff_filespec's sha1_valid member

On Fri, Jun 24, 2016 at 05:29:18PM -0700, Junio C Hamano wrote: > "brian m. carlson" writes: > > > > @@ > > struct diff_filespec o; > > @@ > > - o.sha1_valid > > + o.oid_valid > > > > @@ > > struct diff_filespec *p; > > @@ > > - p->sha1_valid > > + p->oid_valid > > Totally offtopic (from Git's

Re: [PATCH v3 06/11] diff: rename struct diff_filespec's sha1_valid member

"brian m. carlson" writes: > @@ > struct diff_filespec o; > @@ > - o.sha1_valid > + o.oid_valid > > @@ > struct diff_filespec *p; > @@ > - p->sha1_valid > + p->oid_valid Totally offtopic (from Git's point of view), but why does Coccinelle need both of these? I recall that between v1 and v2 the

[PATCH v3 06/11] diff: rename struct diff_filespec's sha1_valid member

Now that this struct's sha1 member is called "oid", update the comment and the sha1_valid member to be called "oid_valid" instead. The following Coccinelle semantic patch was used to implement this, followed by the transformations in object_id.cocci: @@ struct diff_filespec o; @@ - o.sha1_valid +