Re: [PATCH v3 05/44] refs.c: move update_ref to refs.c

2015-10-13 Thread David Turner
On Tue, 2015-10-13 at 05:41 +0200, Michael Haggerty wrote: > The original read > > if (read_ref(pseudoref, actual_old_sha1)) > die("could not read ref '%s'", pseudoref); > > This seems like an important test. What happened to it? > > If its removal was intent

Re: [PATCH v3 05/44] refs.c: move update_ref to refs.c

2015-10-13 Thread David Turner
On Tue, 2015-10-13 at 05:41 +0200, Michael Haggerty wrote: > If its removal was intentional, it deserves a careful explanation (and > should probably be done as a separate commit). If it was an accident, > please consider how this accident arose and try to think about whether > similar accidents m

Re: [PATCH v3 05/44] refs.c: move update_ref to refs.c

2015-10-12 Thread Michael Haggerty
On 10/12/2015 11:51 PM, David Turner wrote: > From: Ronnie Sahlberg > > Move update_ref() to the refs.c file since this function does not > contain any backend specific code. Move the ref classifier functions > as well, since update_ref depends on them. > > Based on Ronnie Sahlberg's patch > >

[PATCH v3 05/44] refs.c: move update_ref to refs.c

2015-10-12 Thread David Turner
From: Ronnie Sahlberg Move update_ref() to the refs.c file since this function does not contain any backend specific code. Move the ref classifier functions as well, since update_ref depends on them. Based on Ronnie Sahlberg's patch Signed-off-by: Ronnie Sahlberg Signed-off-by: David Turner