Re: [PATCH v3 01/14] commit-graph: add format document

2018-02-08 Thread Junio C Hamano
Derrick Stolee writes: > You're right that this data is redundant. It is easy to describe the > width of the tables using the OID length, so it is convenient to have > that part of the format. Also, it is good to have 4-byte alignment > here, so we are not wasting space. > > There isn't a strong

Re: [PATCH v3 01/14] commit-graph: add format document

2018-02-08 Thread Derrick Stolee
On 2/8/2018 4:21 PM, Junio C Hamano wrote: Derrick Stolee writes: Add document specifying the binary format for commit graphs. This format allows for: * New versions. * New hash functions and hash lengths. It still is unclear, at least to me, why OID and OID length are stored as if they can

Re: [PATCH v3 01/14] commit-graph: add format document

2018-02-08 Thread Junio C Hamano
Derrick Stolee writes: > Add document specifying the binary format for commit graphs. This > format allows for: > > * New versions. > * New hash functions and hash lengths. It still is unclear, at least to me, why OID and OID length are stored as if they can be independent. If a reader does not

[PATCH v3 01/14] commit-graph: add format document

2018-02-08 Thread Derrick Stolee
Add document specifying the binary format for commit graphs. This format allows for: * New versions. * New hash functions and hash lengths. * Optional extensions. Basic header information is followed by a binary table of contents into "chunks" that include: * An ordered list of commit object IDs