Re: [PATCH v3 00/33] nd/sha1-name-c-wo-the-repository updates

2019-04-13 Thread Duy Nguyen
On Sat, Apr 13, 2019 at 7:14 PM SZEDER Gábor wrote: > > On Fri, Apr 12, 2019 at 04:25:08PM +0200, Johannes Schindelin wrote: > > Hi, > > > > On Fri, 12 Apr 2019, SZEDER Gábor wrote: > > > > > On Thu, Apr 11, 2019 at 10:58:57PM +0200, SZEDER Gábor wrote: > > > > On Thu, Apr 11, 2019 at 10:51:46PM +

Re: [PATCH v3 00/33] nd/sha1-name-c-wo-the-repository updates

2019-04-13 Thread SZEDER Gábor
On Fri, Apr 12, 2019 at 04:25:08PM +0200, Johannes Schindelin wrote: > Hi, > > On Fri, 12 Apr 2019, SZEDER Gábor wrote: > > > On Thu, Apr 11, 2019 at 10:58:57PM +0200, SZEDER Gábor wrote: > > > On Thu, Apr 11, 2019 at 10:51:46PM +0200, SZEDER Gábor wrote: > > > > On Wed, Apr 10, 2019 at 10:56:52P

Re: [PATCH v3 00/33] nd/sha1-name-c-wo-the-repository updates

2019-04-12 Thread Johannes Schindelin
Hi, On Fri, 12 Apr 2019, SZEDER Gábor wrote: > On Thu, Apr 11, 2019 at 10:58:57PM +0200, SZEDER Gábor wrote: > > On Thu, Apr 11, 2019 at 10:51:46PM +0200, SZEDER Gábor wrote: > > > On Wed, Apr 10, 2019 at 10:56:52PM +0200, Johannes Schindelin wrote: > > > > > ...>} > > > > > > > > > >

Re: [PATCH v3 00/33] nd/sha1-name-c-wo-the-repository updates

2019-04-11 Thread SZEDER Gábor
On Thu, Apr 11, 2019 at 10:58:57PM +0200, SZEDER Gábor wrote: > On Thu, Apr 11, 2019 at 10:51:46PM +0200, SZEDER Gábor wrote: > > On Wed, Apr 10, 2019 at 10:56:52PM +0200, Johannes Schindelin wrote: > > > > ...>} > > > > > > > > @@ > > > > + expression c; > > > > ++expression

Re: [PATCH v3 00/33] nd/sha1-name-c-wo-the-repository updates

2019-04-11 Thread SZEDER Gábor
On Thu, Apr 11, 2019 at 10:51:46PM +0200, SZEDER Gábor wrote: > On Wed, Apr 10, 2019 at 10:56:52PM +0200, Johannes Schindelin wrote: > > > ...>} > > > > > > @@ > > > + expression c; > > > ++expression r; > > > + expression s; > > > + @@ > > > +-- get_commit_tree(c)

Re: [PATCH v3 00/33] nd/sha1-name-c-wo-the-repository updates

2019-04-11 Thread SZEDER Gábor
On Wed, Apr 10, 2019 at 10:56:52PM +0200, Johannes Schindelin wrote: > Hi Duy, > > On Sat, 6 Apr 2019, Nguyễn Thái Ngọc Duy wrote: > > > 10: 68876a150f ! 11: 848456f59c commit.c: add repo_get_commit_tree() > > @@ -2,6 +2,11 @@ > > > > commit.c: add repo_get_commit_tree() > > > >

Re: [PATCH v3 00/33] nd/sha1-name-c-wo-the-repository updates

2019-04-11 Thread Johannes Schindelin
Hi, On Thu, 11 Apr 2019, Duy Nguyen wrote: > On Thu, Apr 11, 2019 at 3:56 AM Johannes Schindelin > wrote: > > > @@ > > > + expression c; > > > ++expression r; > > > + expression s; > > > + @@ > > > +-- get_commit_tree(c) = s > > > ++- repo_get_commit_tree(r, c) = s

Re: [PATCH v3 00/33] nd/sha1-name-c-wo-the-repository updates

2019-04-10 Thread Duy Nguyen
On Thu, Apr 11, 2019 at 3:56 AM Johannes Schindelin wrote: > > @@ > > + expression c; > > ++expression r; > > + expression s; > > + @@ > > +-- get_commit_tree(c) = s > > ++- repo_get_commit_tree(r, c) = s > > + + c->maybe_tree = s > > I think this is wrong, and ad

Re: [PATCH v3 00/33] nd/sha1-name-c-wo-the-repository updates

2019-04-10 Thread Johannes Schindelin
Hi Duy, On Sat, 6 Apr 2019, Nguyễn Thái Ngọc Duy wrote: > 10: 68876a150f ! 11: 848456f59c commit.c: add repo_get_commit_tree() > @@ -2,6 +2,11 @@ > > commit.c: add repo_get_commit_tree() > > +Remove the implicit dependency on the_repository in this function. > +It w

[PATCH v3 00/33] nd/sha1-name-c-wo-the-repository updates

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Hopefully the final fix for commit.cocci in 11/33. Instead of adding more commit details on 01/33 I replaced it with the two commits from Szeder, he put more efforts into them anyway. Range-diff dựa trên v2: 1: b992f6c799 ! 1: aa603ea09e rebase: 'make coccicheck' cleanup @@ -1,6 +1,14 @@