Re: [PATCH v3 00/32] object-store: lookup_commit

2018-07-03 Thread Junio C Hamano
Brandon Williams writes: > I 100% think that we need to continue these refactorings with both the > object store as well as with the_index (removing the index macros and > removing the dependency on global state). The whole compat macros most > definitely was a failed experiment as we still have

Re: [PATCH v3 00/32] object-store: lookup_commit

2018-06-29 Thread Brandon Williams
On 06/29, Junio C Hamano wrote: > Stefan Beller writes: > > > On Fri, Jun 29, 2018 at 11:03 AM Junio C Hamano wrote: > >> > >> Junio C Hamano writes: > >> > >> > One technique these (not just this) recent efforts seem to be > >> > forgetting is to introduce "new" names that take a_repo and then

Re: [PATCH v3 00/32] object-store: lookup_commit

2018-06-29 Thread Junio C Hamano
Stefan Beller writes: > On Fri, Jun 29, 2018 at 11:03 AM Junio C Hamano wrote: >> >> Junio C Hamano writes: >> >> > One technique these (not just this) recent efforts seem to be >> > forgetting is to introduce "new" names that take a_repo and then >> > make the existing one a thin wrapper that

Re: [PATCH v3 00/32] object-store: lookup_commit

2018-06-29 Thread Stefan Beller
On Fri, Jun 29, 2018 at 11:03 AM Junio C Hamano wrote: > > Junio C Hamano writes: > > > One technique these (not just this) recent efforts seem to be > > forgetting is to introduce "new" names that take a_repo and then > > make the existing one a thin wrapper that calls the new one with > > &the_

Re: [PATCH v3 00/32] object-store: lookup_commit

2018-06-29 Thread Junio C Hamano
Junio C Hamano writes: > One technique these (not just this) recent efforts seem to be > forgetting is to introduce "new" names that take a_repo and then > make the existing one a thin wrapper that calls the new one with > &the_repo as the argument. FWIW, here is how I am resolving semantic conf

Re: [PATCH v3 00/32] object-store: lookup_commit

2018-06-29 Thread Junio C Hamano
Stefan Beller writes: > This continues the elimination of global variables in the object store and > teaches lookup_commit[_reference] and alike to handle a_repository. > > This is also available as > https://github.com/stefanbeller/git/tree/object-store-lookup-commit > or applies on top of 02f70

Re: [PATCH v3 00/32] object-store: lookup_commit

2018-06-29 Thread Derrick Stolee
On 6/28/2018 9:21 PM, Stefan Beller wrote: This continues the elimination of global variables in the object store and teaches lookup_commit[_reference] and alike to handle a_repository. This is also available as https://github.com/stefanbeller/git/tree/object-store-lookup-commit or applies on to

[PATCH v3 00/32] object-store: lookup_commit

2018-06-28 Thread Stefan Beller
This continues the elimination of global variables in the object store and teaches lookup_commit[_reference] and alike to handle a_repository. This is also available as https://github.com/stefanbeller/git/tree/object-store-lookup-commit or applies on top of 02f70d63027 (Merge branch 'sb/object-sto