Re: [PATCH v3 00/15] ref-filter: use parsing functions

2016-01-06 Thread Eric Sunshine
On Tue, Jan 5, 2016 at 3:02 AM, Karthik Nayak wrote: > Eric suggested that I make match_atom_name() not return a value [0]. I > haven't done that as we use match_atom_name() in [14/15] for matching > 'subject' and 'body' in contents_atom_parser() and although Eric > suggested I use strcmp() instea

[PATCH v3 00/15] ref-filter: use parsing functions

2016-01-05 Thread Karthik Nayak
This series cleans up populate_value() in ref-filter, by moving out the parsing part of atoms to separate parsing functions. This ensures that parsing is only done once and also improves the modularity of the code. v1: http://thread.gmane.org/gmane.comp.version-control.git/281180 v2: http://thread