Re: [PATCH v3 0/6] Create commit-graph file format v2

2019-05-06 Thread Derrick Stolee
On 5/6/2019 4:27 AM, Christian Couder wrote: > On Fri, May 3, 2019 at 3:44 PM Ævar Arnfjörð Bjarmason > wrote: >> 1) We can stat() the "commit-graphs" directory to see if there's any >>new/deleted ones (dir mtime changed), similar to what we do for the >>untracked cache, and can (but I do

Re: [PATCH v3 0/6] Create commit-graph file format v2

2019-05-06 Thread Christian Couder
On Fri, May 3, 2019 at 3:44 PM Ævar Arnfjörð Bjarmason wrote: > > > On Fri, May 03 2019, Derrick Stolee wrote: > > > On 5/2/2019 2:02 PM, Ævar Arnfjörð Bjarmason wrote: > >> > >> But those are separate from any back-compat concerns, which is what I > >> think makes sense to focus on now. > > > > T

Re: [PATCH v3 0/6] Create commit-graph file format v2

2019-05-03 Thread Derrick Stolee
On 5/3/2019 10:16 AM, SZEDER Gábor wrote: > On Fri, May 03, 2019 at 08:47:25AM -0400, Derrick Stolee wrote: >> It would be much simpler to restrict the model. Your idea of changing >> the file name is the inspiration here. >> >> * The "commit-graph" file is the base commit graph. It is always >>

Re: [PATCH v3 0/6] Create commit-graph file format v2

2019-05-03 Thread SZEDER Gábor
On Fri, May 03, 2019 at 08:47:25AM -0400, Derrick Stolee wrote: > It would be much simpler to restrict the model. Your idea of changing > the file name is the inspiration here. > > * The "commit-graph" file is the base commit graph. It is always > closed under reachability (if a commit exists in

Re: [PATCH v3 0/6] Create commit-graph file format v2

2019-05-03 Thread Ævar Arnfjörð Bjarmason
On Fri, May 03 2019, Derrick Stolee wrote: > On 5/2/2019 2:02 PM, Ævar Arnfjörð Bjarmason wrote: >> >> But those are separate from any back-compat concerns, which is what I >> think makes sense to focus on now. > > Thinking more on this topic, I think I have a way to satisfy _all_ of > your conc

Re: [PATCH v3 0/6] Create commit-graph file format v2

2019-05-03 Thread Derrick Stolee
On 5/2/2019 2:02 PM, Ævar Arnfjörð Bjarmason wrote: > > But those are separate from any back-compat concerns, which is what I > think makes sense to focus on now. Thinking more on this topic, I think I have a way to satisfy _all_ of your concerns by simplifying the plan for incremental commit-grap

Re: [PATCH v3 0/6] Create commit-graph file format v2

2019-05-02 Thread Ævar Arnfjörð Bjarmason
On Thu, May 02 2019, Derrick Stolee wrote: > On 5/1/2019 4:25 PM, Ævar Arnfjörð Bjarmason wrote: >> I won't repeat my outstanding v2 feedback about v1 & v2 >> incompatibilities, except to say that I'd in principle be fine with >> having a v2 format the way this series is adding it. I.e. saying "

Re: [PATCH v3 0/6] Create commit-graph file format v2

2019-05-02 Thread Derrick Stolee
On 5/1/2019 4:25 PM, Ævar Arnfjörð Bjarmason wrote: > I won't repeat my outstanding v2 feedback about v1 & v2 > incompatibilities, except to say that I'd in principle be fine with > having a v2 format the way this series is adding it. I.e. saying "here > it is, it's never written by default, we'll

Re: [PATCH v3 0/6] Create commit-graph file format v2

2019-05-01 Thread Ævar Arnfjörð Bjarmason
On Wed, May 01 2019, Derrick Stolee via GitGitGadget wrote: > The commit-graph file format has some shortcomings that were discussed > on-list: > > 1. It doesn't use the 4-byte format ID from the_hash_algo. > > 2. There is no way to change the reachability index from generation numbers > t

[PATCH v3 0/6] Create commit-graph file format v2

2019-05-01 Thread Derrick Stolee via GitGitGadget
The commit-graph file format has some shortcomings that were discussed on-list: 1. It doesn't use the 4-byte format ID from the_hash_algo. 2. There is no way to change the reachability index from generation numbers to corrected commit date [1]. 3. The unused byte in the