Re: [PATCH v3 0/5] Add --no-ahead-behind to status

2018-01-08 Thread Jeff Hostetler
On 1/8/2018 1:37 AM, Jeff King wrote: On Fri, Jan 05, 2018 at 11:46:24AM -0500, Jeff Hostetler wrote: I'm mildly negative on this "level 2" config. If influencing the porcelain via config creates compatibility headaches, then why would we allow it here? And if it doesn't, then why do we need

Re: [PATCH v3 0/5] Add --no-ahead-behind to status

2018-01-07 Thread Jeff King
On Fri, Jan 05, 2018 at 11:46:24AM -0500, Jeff Hostetler wrote: > > I'm mildly negative on this "level 2" config. If influencing the > > porcelain via config creates compatibility headaches, then why would we > > allow it here? And if it doesn't, then why do we need to protect against > > it? This

Re: [PATCH v3 0/5] Add --no-ahead-behind to status

2018-01-05 Thread Junio C Hamano
Jeff Hostetler writes: > I kinda trying to serve 2 masters here. As we discussed earlier, we > don't want config options to change porcelain formats, hence the > true/false thing only affecting non-porcelain formats. On the other > hand, VS and git.exe are on different release schedules. Norma

Re: [PATCH v3 0/5] Add --no-ahead-behind to status

2018-01-05 Thread Jeff Hostetler
On 1/4/2018 6:06 PM, Jeff King wrote: On Wed, Jan 03, 2018 at 09:47:28PM +, Jeff Hostetler wrote: Config values of true and false control non-porcelain formats for compatibility reasons as previously discussed. In the last commit I added a new value of 2 for the config setting to allow p

Re: [PATCH v3 0/5] Add --no-ahead-behind to status

2018-01-04 Thread Jeff King
On Wed, Jan 03, 2018 at 09:47:28PM +, Jeff Hostetler wrote: > Config values of true and false control non-porcelain formats > for compatibility reasons as previously discussed. In the > last commit I added a new value of 2 for the config setting > to allow porcelain formats to inherit the new

[PATCH v3 0/5] Add --no-ahead-behind to status

2018-01-03 Thread Jeff Hostetler
From: Jeff Hostetler This is version 3 of my patch series to avoid expensive ahead/behind calculations in status. This version tries to address most of the comments in V2. I've switched back to a "status.aheadBehind" config setting rather than in "core.*". This has been better integrated with