Re: [PATCH v3 0/4] rebase: teach rebase --keep-base

2019-04-13 Thread Ævar Arnfjörð Bjarmason
On Sat, Apr 06 2019, Denton Liu wrote: > On Sat, Apr 06, 2019 at 09:44:49PM +0200, Ævar Arnfjörð Bjarmason wrote: >> >> On Mon, Apr 01 2019, Denton Liu wrote: >> >> > Thanks again for your feedback, Ævar! I think we're both on the same page >> > now. >> > Hopefully I've addressed all of your hi

Re: [PATCH v3 0/4] rebase: teach rebase --keep-base

2019-04-06 Thread Denton Liu
On Sat, Apr 06, 2019 at 09:44:49PM +0200, Ævar Arnfjörð Bjarmason wrote: > > On Mon, Apr 01 2019, Denton Liu wrote: > > > Thanks again for your feedback, Ævar! I think we're both on the same page > > now. > > Hopefully I've addressed all of your high-level concerns with this patchset > > and >

Re: [PATCH v3 0/4] rebase: teach rebase --keep-base

2019-04-06 Thread Ævar Arnfjörð Bjarmason
On Mon, Apr 01 2019, Denton Liu wrote: > Thanks again for your feedback, Ævar! I think we're both on the same page now. > Hopefully I've addressed all of your high-level concerns with this patchset > and > we can move into a discussion on implementation detail. Late in replying to this, have b

[PATCH v3 0/4] rebase: teach rebase --keep-base

2019-04-01 Thread Denton Liu
Thanks again for your feedback, Ævar! I think we're both on the same page now. Hopefully I've addressed all of your high-level concerns with this patchset and we can move into a discussion on implementation detail. This patchset now depends "[PATCH 1/8] tests (rebase): spell out the `--keep-empty`