Re: [PATCH v3 0/4] completion.commands: fix multiple command removals

2019-03-21 Thread Todd Zullinger
Junio C Hamano wrote: > Todd Zullinger writes: > >> Other than a follow-up to update the commit reference in 4/4 >> after 1/4 is in the final form on pu, I think this might be good. >> If it's easier, we can skip 4/4 and I'll resend it after the >> others are on pu. > > A series that makes a sin

Re: [PATCH v3 0/4] completion.commands: fix multiple command removals

2019-03-21 Thread Duy Nguyen
On Thu, Mar 21, 2019 at 1:03 AM Todd Zullinger wrote: > > Hi, > > Duy Nguyen wrote: > > You probably want to drop the comment block about repository setup > > inside list_cmds_by_config() too. > > You're right, of course. Thanks Duy. :) > > That's the only change since v2. The range-diff looks o

Re: [PATCH v3 0/4] completion.commands: fix multiple command removals

2019-03-20 Thread Junio C Hamano
Todd Zullinger writes: > Other than a follow-up to update the commit reference in 4/4 > after 1/4 is in the final form on pu, I think this might be good. > If it's easier, we can skip 4/4 and I'll resend it after the > others are on pu. A series that makes a single topic should expect to be read

[PATCH v3 0/4] completion.commands: fix multiple command removals

2019-03-20 Thread Todd Zullinger
Hi, Duy Nguyen wrote: > You probably want to drop the comment block about repository setup > inside list_cmds_by_config() too. You're right, of course. Thanks Duy. :) That's the only change since v2. Other than a follow-up to update the commit reference in 4/4 after 1/4 is in the final form on