Re: [PATCH v3 0/3] Improve robustness of putty detection

2015-04-28 Thread brian m. carlson
On Sun, Apr 26, 2015 at 03:04:56PM -0700, Junio C Hamano wrote: > Good eyes. While fixing the test is necessary, we should also be > able to improve the test framework to prevent such mistakes at the > same time. > > ok 38 # skip > git clone "[myhost:123]:src" ssh-bracket-clone && >

Re: [PATCH v3 0/3] Improve robustness of putty detection

2015-04-27 Thread Jeff King
On Sun, Apr 26, 2015 at 03:04:56PM -0700, Junio C Hamano wrote: > The test scripts are expected to take either 3 or 4 parameters, and > the extra parameter when it takes 4 is the comma separated list of > prerequisites. "bracketed hostnames are still ssh" does not look > like prerequisites at all

Re: [PATCH v3 0/3] Improve robustness of putty detection

2015-04-27 Thread Torsten Bögershausen
On 04/27/2015 12:04 AM, Junio C Hamano wrote: > "brian m. carlson" writes: > >> While I was adding tests, I noticed that we had a broken test due to the >> use of single quotes within a test, which resulted in the test always >> being skipped. > > Good eyes. While fixing the test is necessary,

Re: [PATCH v3 0/3] Improve robustness of putty detection

2015-04-26 Thread Junio C Hamano
"brian m. carlson" writes: > While I was adding tests, I noticed that we had a broken test due to the > use of single quotes within a test, which resulted in the test always > being skipped. Good eyes. While fixing the test is necessary, we should also be able to improve the test framework to p

[PATCH v3 0/3] Improve robustness of putty detection

2015-04-26 Thread brian m. carlson
This series improves detection of plink (the putty utility). While I was adding tests, I noticed that we had a broken test due to the use of single quotes within a test, which resulted in the test always being skipped. Therefore, nobody noticed that the test was actually broken. brian m. carlson