Re: [PATCH v3 0/2] Make git-svn work with gitdir links

2013-01-24 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > > diff --git a/git-svn.perl b/git-svn.perl > > index c232798..e5bd292 100755 > > --- a/git-svn.perl > > +++ b/git-svn.perl > > @@ -332,11 +332,13 @@ if ($cmd && $cmd =~ /(?:clone|init|multi-init)$/) { > > $ENV{GIT_DIR} = command_oneline([

Re: [PATCH v3 0/2] Make git-svn work with gitdir links

2013-01-23 Thread Junio C Hamano
Eric Wong writes: > diff --git a/git-svn.perl b/git-svn.perl > index c232798..e5bd292 100755 > --- a/git-svn.perl > +++ b/git-svn.perl > @@ -332,11 +332,13 @@ if ($cmd && $cmd =~ /(?:clone|init|multi-init)$/) { > $ENV{GIT_DIR} = command_oneline([qw/rev-parse --git-dir/]); > }

Re: [PATCH v3 0/2] Make git-svn work with gitdir links

2013-01-23 Thread Eric Wong
Barry Wardell wrote: > On Wed, Jan 23, 2013 at 2:32 AM, Eric Wong wrote: > > Does squashing this on top of your changes fix all your failures? > > I plan on squashing both your changes together with the below: > > Yes, I can confirm that applying this patch on top of mine makes all > git-svn tes

Re: [PATCH v3 0/2] Make git-svn work with gitdir links

2013-01-23 Thread Barry Wardell
On Wed, Jan 23, 2013 at 2:32 AM, Eric Wong wrote: > > Barry Wardell wrote: > > These patches fix a bug which prevented git-svn from working with > > repositories > > which use gitdir links. > > > > Changes since v2: > > - Rebased onto latest master. > > - Added test case which verifies that th

Re: [PATCH v3 0/2] Make git-svn work with gitdir links

2013-01-22 Thread Junio C Hamano
Eric Wong writes: > `git rev-parse --show-cdup` outputs nothing if GIT_DIR is set, > so I unset GIT_DIR temporarily. > > I'm not sure why --show-cdup behaves like this, though.. Setting GIT_DIR is to say "That is the directory that has the repository objects and refs; I am letting you know the l

Re: [PATCH v3 0/2] Make git-svn work with gitdir links

2013-01-22 Thread Eric Wong
Barry Wardell wrote: > These patches fix a bug which prevented git-svn from working with repositories > which use gitdir links. > > Changes since v2: > - Rebased onto latest master. > - Added test case which verifies that the problem has been fixed. > - Fixed problems with git svn (init|clone|

Re: [PATCH v3 0/2] Make git-svn work with gitdir links

2013-01-21 Thread Junio C Hamano
"Philip Oakley" writes: > From: "Joachim Schmitz" > Sent: Monday, January 21, 2013 2:19 PM >> Junio C Hamano wrote: >>> Barry Wardell writes: > [...] >>> Thanks for your persistence ;-) As this is a pretty old topic, I'll >>> give two URLs for people who are interested to view the previous >>>

Re: [PATCH v3 0/2] Make git-svn work with gitdir links

2013-01-21 Thread Philip Oakley
From: "Joachim Schmitz" Sent: Monday, January 21, 2013 2:19 PM Junio C Hamano wrote: Barry Wardell writes: [...] Thanks for your persistence ;-) As this is a pretty old topic, I'll give two URLs for people who are interested to view the previous threads: http://thread.gmane.org/gmane.com

Re: [PATCH v3 0/2] Make git-svn work with gitdir links

2013-01-21 Thread Joachim Schmitz
Junio C Hamano wrote: Barry Wardell writes: These patches fix a bug which prevented git-svn from working with repositories which use gitdir links. Changes since v2: - Rebased onto latest master. - Added test case which verifies that the problem has been fixed. - Fixed problems with git svn

Re: [PATCH v3 0/2] Make git-svn work with gitdir links

2013-01-20 Thread Junio C Hamano
Barry Wardell writes: > These patches fix a bug which prevented git-svn from working with repositories > which use gitdir links. > > Changes since v2: > - Rebased onto latest master. > - Added test case which verifies that the problem has been fixed. > - Fixed problems with git svn (init|clone

[PATCH v3 0/2] Make git-svn work with gitdir links

2013-01-20 Thread Barry Wardell
These patches fix a bug which prevented git-svn from working with repositories which use gitdir links. Changes since v2: - Rebased onto latest master. - Added test case which verifies that the problem has been fixed. - Fixed problems with git svn (init|clone|multi-init). - All git-svn test cas