Re: [PATCH v3] transport-helper: enforce atomic in push_refs_with_push

2019-07-12 Thread Junio C Hamano
Emily Shaffer writes: > +test_expect_success 'push --atomic also prevents branch creation, reports > collateral' ' > + # Setup upstream repo - empty for now > + d=$HTTPD_DOCUMENT_ROOT_PATH/atomic-branches.git && > + git init --bare "$d" && > + test_config -C "$d" http.receivepack

[PATCH v3] transport-helper: enforce atomic in push_refs_with_push

2019-07-11 Thread Emily Shaffer
Teach transport-helper how to notice if skipping a ref during push would violate atomicity on the client side. We notice that a ref would be rejected, and choose not to send it, but don't notice that if the client has asked for --atomic we are violating atomicity if all the other pushes we are send