Re: [PATCH v3] remote-hg: do not fail on invalid bookmarks

2014-03-22 Thread Torsten Bögershausen
On 2014-03-21 23.32, Junio C Hamano wrote: > Max Horn writes: > >> Hi Torsten, >> >> On 21.03.2014, at 21:47, Torsten Bögershausen wrote: >> >>> On 2014-03-21 12.36, Max Horn wrote: >>> All tests passed :-), >> >> Excellent. >> >>> thanks from my side. >>> comments inline, some are debatable >>

Re: [PATCH v3] remote-hg: do not fail on invalid bookmarks

2014-03-21 Thread Junio C Hamano
Max Horn writes: > Hi Torsten, > > On 21.03.2014, at 21:47, Torsten Bögershausen wrote: > >> On 2014-03-21 12.36, Max Horn wrote: >> All tests passed :-), > > Excellent. > >> thanks from my side. >> comments inline, some are debatable > > Thanks for having a close look and for the constructive f

Re: [PATCH v3] remote-hg: do not fail on invalid bookmarks

2014-03-21 Thread Max Horn
Hi Torsten, On 21.03.2014, at 21:47, Torsten Bögershausen wrote: > On 2014-03-21 12.36, Max Horn wrote: > All tests passed :-), Excellent. > thanks from my side. > comments inline, some are debatable Thanks for having a close look and for the constructive feedback! Unfortunately, I won't have

Re: [PATCH v3] remote-hg: do not fail on invalid bookmarks

2014-03-21 Thread Torsten Bögershausen
On 2014-03-21 12.36, Max Horn wrote: All tests passed :-), thanks from my side. comments inline, some are debatable > Mercurial can have bookmarks pointing to "nullid" (the empty root > revision), while Git can not have references to it. When cloning or > fetching from a Mercurial repository that h

[PATCH v3] remote-hg: do not fail on invalid bookmarks

2014-03-21 Thread Max Horn
Mercurial can have bookmarks pointing to "nullid" (the empty root revision), while Git can not have references to it. When cloning or fetching from a Mercurial repository that has such a bookmark, the import failed because git-remote-hg was not be able to create the corresponding reference. Warn t