Re: [PATCH v3] remote: add get-url subcommand

2015-08-05 Thread Junio C Hamano
Ben Boeckel writes: > On Wed, Aug 05, 2015 at 13:34:18 -0700, Junio C Hamano wrote: >> Changes to these two files look reasonable. >> >> Don't you want to protect this feature from future breakage by >> others by adding a couple of tests, though, to t/t5505? > > Thanks, I've done so locally. It

Re: [PATCH v3] remote: add get-url subcommand

2015-08-05 Thread Ben Boeckel
On Wed, Aug 05, 2015 at 13:34:18 -0700, Junio C Hamano wrote: > Changes to these two files look reasonable. > > Don't you want to protect this feature from future breakage by > others by adding a couple of tests, though, to t/t5505? Thanks, I've done so locally. It actually brings up this case:

Re: [PATCH v3] remote: add get-url subcommand

2015-08-05 Thread Junio C Hamano
Ben Boeckel writes: > Expanding `insteadOf` is a part of ls-remote --url and there is no way > to expand `pushInsteadOf` as well. Add a get-url subcommand to be able > to query both as well as a way to get all configured urls. > > Signed-off-by: Ben Boeckel > --- > Documentation/git-remote.txt

[PATCH v3] remote: add get-url subcommand

2015-08-04 Thread Ben Boeckel
Expanding `insteadOf` is a part of ls-remote --url and there is no way to expand `pushInsteadOf` as well. Add a get-url subcommand to be able to query both as well as a way to get all configured urls. Signed-off-by: Ben Boeckel --- Documentation/git-remote.txt | 10 builtin/remote.c