Re: [PATCH v3] remote: add --fetch and --both options to set-url

2014-12-17 Thread Jeff King
On Wed, Dec 17, 2014 at 03:20:58PM +0100, Peter Wu wrote: > > There are 2 warning "dangling else", line 1570 and 1578 > > I think we should use: > > > > for (i = 0; i < remote->pushurl_nr; i++) { > > if (!regexec(&old_regex, remote->pushurl[i], 0,

Re: [PATCH v3] remote: add --fetch and --both options to set-url

2014-12-17 Thread Peter Wu
On Wednesday 17 December 2014 11:08:07 Torsten Bögershausen wrote: > On 11/25/2014 12:48 PM, Peter Wu wrote: > > git remote set-url knew about the '--push' option to update just the > > pushurl, but it does not have a similar option for "update fetch URL and > > leave whatever was in place for the

Re: [PATCH v3] remote: add --fetch and --both options to set-url

2014-12-17 Thread Torsten Bögershausen
On 11/25/2014 12:48 PM, Peter Wu wrote: git remote set-url knew about the '--push' option to update just the pushurl, but it does not have a similar option for "update fetch URL and leave whatever was in place for the push URL". This patch adds support for a '--fetch' option which implements tha

Re: [PATCH v3] remote: add --fetch and --both options to set-url

2014-12-04 Thread Jeff King
On Tue, Nov 25, 2014 at 12:48:26PM +0100, Peter Wu wrote: > git remote set-url knew about the '--push' option to update just the > pushurl, but it does not have a similar option for "update fetch URL and > leave whatever was in place for the push URL". > > This patch adds support for a '--fetch'

Re: [PATCH v3] remote: add --fetch and --both options to set-url

2014-11-25 Thread Peter Wu
On Tuesday 25 November 2014 17:09:04 Eric Sunshine wrote: > On Tue, Nov 25, 2014 at 6:48 AM, Peter Wu wrote: > > git remote set-url knew about the '--push' option to update just the > > pushurl, but it does not have a similar option for "update fetch URL and > > leave whatever was in place for the

Re: [PATCH v3] remote: add --fetch and --both options to set-url

2014-11-25 Thread Eric Sunshine
On Tue, Nov 25, 2014 at 6:48 AM, Peter Wu wrote: > git remote set-url knew about the '--push' option to update just the > pushurl, but it does not have a similar option for "update fetch URL and > leave whatever was in place for the push URL". > > This patch adds support for a '--fetch' option whi

[PATCH v3] remote: add --fetch and --both options to set-url

2014-11-25 Thread Peter Wu
git remote set-url knew about the '--push' option to update just the pushurl, but it does not have a similar option for "update fetch URL and leave whatever was in place for the push URL". This patch adds support for a '--fetch' option which implements that use case in a backwards compatible way: