Re: [PATCH v3] reflog-walk: don't segfault on non-commit sha1's in the reflog

2015-12-31 Thread Dennis Kaarsemaker
On do, 2015-12-31 at 09:57 +0100, Dennis Kaarsemaker wrote: > > > +test_expect_success 'reflog containing non-commit sha1s displays > > > properly' ' > > > > In general, "properly" is a poor word to use in test description > (or > > a commit log message or a bug report, for that matter), as the >

Re: [PATCH v3] reflog-walk: don't segfault on non-commit sha1's in the reflog

2015-12-31 Thread Dennis Kaarsemaker
On wo, 2015-12-30 at 16:02 -0800, Junio C Hamano wrote: > Dennis Kaarsemaker writes: > > > diff --git a/reflog-walk.c b/reflog-walk.c > > index 85b8a54..0ebd1da 100644 > > --- a/reflog-walk.c > > +++ b/reflog-walk.c > > @@ -221,6 +221,7 @@ void fake_reflog_parent(struct reflog_walk_info > > *info

Re: [PATCH v3] reflog-walk: don't segfault on non-commit sha1's in the reflog

2015-12-30 Thread Junio C Hamano
Dennis Kaarsemaker writes: > This turned out to be doable in the same code segment: just keep on > processing reflog entries until you hit a commit or run out of entries. > That (and the updated foremerly-failing test) are the only changes > between v2 and v3. > > I'll try to actually implement t

[PATCH v3] reflog-walk: don't segfault on non-commit sha1's in the reflog

2015-12-30 Thread Dennis Kaarsemaker
git reflog (ab)uses the log machinery to display its list of log entries. To do so it must fake commit parent information for the log walker. For refs in refs/heads this is no problem, as they should only ever point to commits. Tags and other refs however can point to anything, thus their reflog m