Re: [PATCH v3] rebase: remove the rebase.useBuiltin setting

2019-03-18 Thread Phillip Wood
Hi Ævar Thanks for doing this, it's great to see it from a maintenance perspective as well as it meaning the builtin rebase is considered stable. A couple small nit picks below On 15/03/2019 13:45, Ævar Arnfjörð Bjarmason wrote: Remove the rebase.useBuiltin setting, which was added as an esc

Re: [PATCH v3] rebase: remove the rebase.useBuiltin setting

2019-03-17 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Urgh, Junio: If there's no other comments/concerns on v3 requiring a v4 > this has my: > > Signed-off-by: Ævar Arnfjörð Bjarmason Alright. Let's queue, wait for a while to see if there is anything else and continue. Thanks.

Re: [PATCH v3] rebase: remove the rebase.useBuiltin setting

2019-03-15 Thread Ævar Arnfjörð Bjarmason
On Fri, Mar 15 2019, Johannes Schindelin wrote: > Hi Ævar, > > On Fri, 15 Mar 2019, Ævar Arnfjörð Bjarmason wrote: > >> Remove the rebase.useBuiltin setting, which was added as an escape >> hatch to disable the builtin version of rebase first released with Git >> 2.20. >> >> See [1] for the init

Re: [PATCH v3] rebase: remove the rebase.useBuiltin setting

2019-03-15 Thread Johannes Schindelin
Hi Ævar, On Fri, 15 Mar 2019, Ævar Arnfjörð Bjarmason wrote: > Remove the rebase.useBuiltin setting, which was added as an escape > hatch to disable the builtin version of rebase first released with Git > 2.20. > > See [1] for the initial implementation of rebase.useBuiltin, and [2] > and [3] fo

[PATCH v3] rebase: remove the rebase.useBuiltin setting

2019-03-15 Thread Ævar Arnfjörð Bjarmason
Remove the rebase.useBuiltin setting, which was added as an escape hatch to disable the builtin version of rebase first released with Git 2.20. See [1] for the initial implementation of rebase.useBuiltin, and [2] and [3] for the documentation and corresponding GIT_TEST_REBASE_USE_BUILTIN option.