Re: [PATCH v3] promisor-remote: skip move_to_tail when no-op

2019-09-30 Thread Jeff King
On Mon, Sep 30, 2019 at 01:28:18PM -0700, Emily Shaffer wrote: > Previously, when promisor_remote_move_to_tail() is called for a > promisor_remote which is currently the final element in promisors, a > cycle is created in the promisors linked list. This cycle leads to a > double free later on in p

[PATCH v3] promisor-remote: skip move_to_tail when no-op

2019-09-30 Thread Emily Shaffer
Previously, when promisor_remote_move_to_tail() is called for a promisor_remote which is currently the final element in promisors, a cycle is created in the promisors linked list. This cycle leads to a double free later on in promisor_remote_clear() when the final element of the promisors list is r