Re: [PATCH v3] gitk: Add a "Copy commit summary" command

2015-07-17 Thread Beat Bolli
On 17.07.15 19:28, Junio C Hamano wrote: > Eric Sunshine writes: > >>> Signed-off-by: Beat Bolli >>> Reviewed-by: Eric Sunshine >>> Reviewed-by: Johannes Sixt >> >> You should drop these Reviewed-by: footers, as they imply that the >> code was thoroughly digested and the implementation deemed

Re: [PATCH v3] gitk: Add a "Copy commit summary" command

2015-07-17 Thread Junio C Hamano
Eric Sunshine writes: >> Signed-off-by: Beat Bolli >> Reviewed-by: Eric Sunshine >> Reviewed-by: Johannes Sixt > > You should drop these Reviewed-by: footers, as they imply that the > code was thoroughly digested and the implementation deemed correct. ... and the most importantly, the named p

Re: [PATCH v3] gitk: Add a "Copy commit summary" command

2015-07-17 Thread Eric Sunshine
On Fri, Jul 17, 2015 at 4:39 AM, Beat Bolli wrote: > When referring to earlier commits in commit messages or other text, one > of the established formats is > > ("", ) > > Add a "Copy commit summary" command to the context menu that puts this > text for the currently selected commit on the cl

[PATCH v3] gitk: Add a "Copy commit summary" command

2015-07-17 Thread Beat Bolli
When referring to earlier commits in commit messages or other text, one of the established formats is ("", ) Add a "Copy commit summary" command to the context menu that puts this text for the currently selected commit on the clipboard. This makes it easy for our users to create well-format