Re: [PATCH v3] git-submodule.sh: shorten submodule SHA-1s using rev-parse

2019-02-04 Thread Eric Sunshine
On Mon, Feb 4, 2019 at 1:47 PM Junio C Hamano wrote: > Eric Sunshine writes: > > On Sun, Feb 3, 2019 at 4:01 PM Sven van Haastregt wrote: > >> We cannot always rely on successfully invoking `git rev-parse` in the > >> submodule directory. Keep the old method using `cut` as a fallback. > > > > R

Re: [PATCH v3] git-submodule.sh: shorten submodule SHA-1s using rev-parse

2019-02-04 Thread Junio C Hamano
Eric Sunshine writes: > On Sun, Feb 3, 2019 at 4:01 PM Sven van Haastregt wrote: >> Until now, `git submodule summary` was always emitting 7-character >> SHA-1s that have a higher chance of being ambiguous for larger >> repositories. Use `git rev-parse --short` instead, which will >> determine

Re: [PATCH v3] git-submodule.sh: shorten submodule SHA-1s using rev-parse

2019-02-03 Thread Eric Sunshine
On Sun, Feb 3, 2019 at 4:01 PM Sven van Haastregt wrote: > Until now, `git submodule summary` was always emitting 7-character > SHA-1s that have a higher chance of being ambiguous for larger > repositories. Use `git rev-parse --short` instead, which will > determine suitable short SHA-1 lengths.

[PATCH v3] git-submodule.sh: shorten submodule SHA-1s using rev-parse

2019-02-03 Thread Sven van Haastregt
Until now, `git submodule summary` was always emitting 7-character SHA-1s that have a higher chance of being ambiguous for larger repositories. Use `git rev-parse --short` instead, which will determine suitable short SHA-1 lengths. We cannot always rely on successfully invoking `git rev-parse` in