Re: [PATCH v3] git-p4: add "--path-encoding" option

2015-09-01 Thread Junio C Hamano
Lars Schneider writes: > I searched the Internet for clues around cp1252 and found that a > similar patch was submitted to Mercurial just a month ago. The author > seconds my cp1252 observation: > http://mercurial.808500.n3.nabble.com/PATCH-stable-convert-use-original-local-encoding-when-converti

Re: [PATCH v3] git-p4: add "--path-encoding" option

2015-09-01 Thread Lars Schneider
On 01 Sep 2015, at 19:35, Junio C Hamano wrote: > Lars Schneider writes: > >> On 01 Sep 2015, at 01:13, Junio C Hamano wrote: >> >>> larsxschnei...@gmail.com writes: >>> From: Lars Schneider >>> >>> Here is a space for you to describe what it does and why it is a >>> good idea

Re: [PATCH v3] git-p4: add "--path-encoding" option

2015-09-01 Thread Junio C Hamano
Lars Schneider writes: > On 01 Sep 2015, at 01:13, Junio C Hamano wrote: > >> larsxschnei...@gmail.com writes: >> >>> From: Lars Schneider >>> >> >> Here is a space for you to describe what it does and why it is a >> good idea to have it. > How about this: > > Perforce keeps the encoding of

Re: [PATCH v3] git-p4: add "--path-encoding" option

2015-09-01 Thread Junio C Hamano
Lars Schneider writes: >> I'll move this to 9822, as 9821 is taken by another git-p4 test, >> while queuing. > OK. I wasn’t sure how this is handled. Just for my understanding: As > soon as a TC number is occupied in one of the official branches > (master/next/pu/maint) then the next number shoul

Re: [PATCH v3] git-p4: add "--path-encoding" option

2015-09-01 Thread Lars Schneider
On 01 Sep 2015, at 16:35, Torsten Bögershausen wrote: > On 2015-09-01 14.47, Lars Schneider wrote: +test_expect_success 'Create a repo containing iso8859-1 encoded paths' ' >> +cd "$cli" && >> + >> +ISO8859="$(printf "$UTF8_ESCAPED" | iconv -f utf-8 -t >> is

Re: [PATCH v3] git-p4: add "--path-encoding" option

2015-09-01 Thread Torsten Bögershausen
On 2015-09-01 14.47, Lars Schneider wrote: >>> +test_expect_success 'Create a repo containing iso8859-1 encoded paths' ' >>> >> +cd "$cli" && >>> >> + >>> >> +ISO8859="$(printf "$UTF8_ESCAPED" | iconv -f utf-8 -t >>> >> iso8859-1)" && >>> >> +>"$ISO8859" && >>> >> +

Re: [PATCH v3] git-p4: add "--path-encoding" option

2015-09-01 Thread Lars Schneider
On 01 Sep 2015, at 01:13, Junio C Hamano wrote: > larsxschnei...@gmail.com writes: > >> From: Lars Schneider >> > > Here is a space for you to describe what it does and why it is a > good idea to have it. How about this: Perforce keeps the encoding of a path as given by the originating OS.

Re: [PATCH v3] git-p4: add "--path-encoding" option

2015-09-01 Thread Lars Schneider
On 01 Sep 2015, at 06:37, Torsten Bögershausen wrote: > On 01/09/15 00:10, larsxschnei...@gmail.com wrote: >> From: Lars Schneider >> >> Signed-off-by: Lars Schneider >> --- >> Documentation/git-p4.txt| 5 + >> git-p4.py | 6 ++ >> t/t9821-git-p4-path-

Fwd: Re: [PATCH v3] git-p4: add "--path-encoding" option

2015-09-01 Thread Torsten Bögershausen
Sorry if this is possible re-sending Forwarded Message Subject:Re: [PATCH v3] git-p4: add "--path-encoding" option Date: Tue, 1 Sep 2015 06:37:59 +0200 From: Torsten Bögershausen To: larsxschnei...@gmail.com, git@vger.kernel.org CC: l...@diamand

Re: [PATCH v3] git-p4: add "--path-encoding" option

2015-08-31 Thread Torsten Bögershausen
On 01/09/15 00:10, larsxschnei...@gmail.com wrote: From: Lars Schneider Signed-off-by: Lars Schneider --- Documentation/git-p4.txt| 5 + git-p4.py | 6 ++ t/t9821-git-p4-path-encoding.sh | 38 ++ 3 files changed

Re: [PATCH v3] git-p4: add "--path-encoding" option

2015-08-31 Thread Junio C Hamano
larsxschnei...@gmail.com writes: > From: Lars Schneider > Here is a space for you to describe what it does and why it is a good idea to have it. > Signed-off-by: Lars Schneider > --- > Documentation/git-p4.txt| 5 + > git-p4.py | 6 ++ > t/t9821-git-p4-

[PATCH v3] git-p4: add "--path-encoding" option

2015-08-31 Thread larsxschneider
From: Lars Schneider Signed-off-by: Lars Schneider --- Documentation/git-p4.txt| 5 + git-p4.py | 6 ++ t/t9821-git-p4-path-encoding.sh | 38 ++ 3 files changed, 49 insertions(+) create mode 100755 t/t9821-git-p4-path-

[PATCH v3] git-p4: add "--path-encoding" option

2015-08-31 Thread larsxschneider
From: Lars Schneider Diff to v2: * remove comment * use "core.quotepath false" to simplify test case Unit test passed on OS X and Linux. The unit test did also pass on v2 as "printf $(git ls-files) >actual" removes the LF. Cheers, Lars Lars Schneider (1): git-p4: add "--path-encoding" optio