Re: [PATCH v3] git-completion.bash: add support for path completion

2012-12-19 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 19/12/2012 20:57, Junio C Hamano ha scritto: > [...] I just found a serious bug with "git commit" path completion. When doing the first commit on an empty repository, completion will cause an error: $git commit -m init fatal: ambiguous argument '

Re: [PATCH v3] git-completion.bash: add support for path completion

2012-12-19 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 19/12/2012 20:57, Junio C Hamano ha scritto: > [jch: again, adding area experts to Cc] > > Manlio Perillo writes: > >> Changes from version 2: >> >> * Perl is no more used. >> * Fixed some coding style issues. >> * Refactorized cod

Re: [PATCH v3] git-completion.bash: add support for path completion

2012-12-19 Thread Junio C Hamano
[jch: again, adding area experts to Cc] Manlio Perillo writes: > Changes from version 2: > > * Perl is no more used. > * Fixed some coding style issues. > * Refactorized code, to improve future path completion support for > the "git reset" command. Thanks. Will replac

[PATCH v3] git-completion.bash: add support for path completion

2012-12-19 Thread Manlio Perillo
The git-completion.bash script did not implemented full, git aware, support to complete paths, for git commands that operate on files within the current working directory or the index. As an example: git add will suggest all files in the current working directory, including ignored file

Re: [PATCH v3] git-completion.bash: add support for path completion

2012-12-18 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 18/12/2012 20:22, Junio C Hamano ha scritto: > [...] >> Note that the performance is the reason why I suggested, in a previous >> email, that git should have some more options to format data in custom ways. >> As an example, there is no way to tell

Re: [PATCH v3] git-completion.bash: add support for path completion

2012-12-18 Thread Junio C Hamano
Manlio Perillo writes: > Il 18/12/2012 18:53, Junio C Hamano ha scritto: >> [jch: cc'ed git-completion experts to review implementation details] >> >> Manlio Perillo writes: >> >>> The git-completion.bash script did not implemented full, git aware, >>> support for completion, for git commands

Re: [PATCH v3] git-completion.bash: add support for path completion

2012-12-18 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 18/12/2012 18:53, Junio C Hamano ha scritto: > [jch: cc'ed git-completion experts to review implementation details] > > Manlio Perillo writes: > >> The git-completion.bash script did not implemented full, git aware, >> support for completion, for

Re: [PATCH v3] git-completion.bash: add support for path completion

2012-12-18 Thread Junio C Hamano
[jch: cc'ed git-completion experts to review implementation details] Manlio Perillo writes: > The git-completion.bash script did not implemented full, git aware, > support for completion, for git commands that operate on files within > the current working directory or the index. > > For these co

[PATCH v3] git-completion.bash: add support for path completion

2012-12-18 Thread Manlio Perillo
The git-completion.bash script did not implemented full, git aware, support for completion, for git commands that operate on files within the current working directory or the index. For these commands, only long options completion was available. As an example: git add will suggest all f