Re: [PATCH v3] git-clean: Display more accurate delete messages

2013-01-03 Thread Zoltan Klinger
> The updated code structure is much nicer than the previous round, > but I am somewhat puzzled how return value of remove_dirs() and > &gone relate to each other. Surely when gone is set to zero, > remove_dirs() is reporting that the directory it was asked to remove > recursively did not go away,

Re: [PATCH v3] git-clean: Display more accurate delete messages

2013-01-02 Thread Junio C Hamano
Junio C Hamano writes: > Zoltan Klinger writes: > >> +static const char* MSG_REMOVE = "Removing %s\n"; >> +static const char* MSG_WOULD_REMOVE = "Would remove %s\n"; >> +static const char* MSG_WOULD_NOT_REMOVE = "Would not remove %s\n"; I also noticed that this message is not used, which mwans

Re: [PATCH v3] git-clean: Display more accurate delete messages

2013-01-02 Thread Junio C Hamano
Zoltan Klinger writes: > +static const char* MSG_REMOVE = "Removing %s\n"; > +static const char* MSG_WOULD_REMOVE = "Would remove %s\n"; > +static const char* MSG_WOULD_NOT_REMOVE = "Would not remove %s\n"; > +static const char* MSG_WOULD_IGNORE_GIT_DIR = "Would ignore untracked git > repository

[PATCH v3] git-clean: Display more accurate delete messages

2013-01-01 Thread Zoltan Klinger
(1) Only print out the names of the files and directories that got actually deleted. (2) Show warning message for ignored untracked git repositories Consider the following repo layout: test.git/ |-- tracked_dir/ | |-- some_tracked_file | |-- some_untracked_file |-- t