Re: [PATCH v3] format-patch --signature-file

2014-05-18 Thread Jeremiah Mahler
Peff, Lots of good suggestions. I had to expand upon the signature pattern match to get to work. On Sun, May 18, 2014 at 07:20:20AM -0400, Jeff King wrote: > On Sat, May 17, 2014 at 09:02:22AM -0700, Jeremiah Mahler wrote: > ... > > +test_expect_success 'format-patch --signature-file file' ' >

Re: [PATCH v3] format-patch --signature-file

2014-05-18 Thread Jeff King
On Sat, May 17, 2014 at 09:02:22AM -0700, Jeremiah Mahler wrote: > Added feature that allows a signature file to be used with format-patch. > > $ git format-patch --signature-file ~/.signature -1 > > Now signatures with newlines and other special characters can be > easily included. > > Signe

[PATCH v3] format-patch --signature-file

2014-05-17 Thread Jeremiah Mahler
Added feature that allows a signature file to be used with format-patch. $ git format-patch --signature-file ~/.signature -1 Now signatures with newlines and other special characters can be easily included. Signed-off-by: Jeremiah Mahler --- Documentation/git-format-patch.txt | 4 buil

[PATCH v3] format-patch --signature-file

2014-05-17 Thread Jeremiah Mahler
v3 patch to add format-patch --signature-file option. This revision includes changes suggested by Jeff King: - Instead of a custom OPTION_CALLBACK, use OPT_FILENAME which correctly resolves file names which are not evaluated by the shell such as "--signature-file=" - Use str