Re: [PATCH v3] fetch-pack: fix object_id of exact sha1

2016-03-03 Thread Jeff King
On Thu, Mar 03, 2016 at 08:35:54PM -0300, Gabriel Souza Franco wrote: > > The code looks good to me. Do we need documentation or test updates? > > > > Here's a test that can be squashed in. For documentation, it looks like > > we don't cover the " " form at all. That's maybe OK, as it's > > mostly

Re: [PATCH v3] fetch-pack: fix object_id of exact sha1

2016-03-03 Thread Gabriel Souza Franco
On Tue, Mar 1, 2016 at 1:54 AM, Jeff King wrote: > On Mon, Feb 29, 2016 at 11:12:56PM -0300, Gabriel Souza Franco wrote: > >> Commit 58f2ed0 (remote-curl: pass ref SHA-1 to fetch-pack as well, >> 2013-12-05) added support for specifying a SHA-1 as well as a ref name. >> Add support for specifying

Re: [PATCH v3] fetch-pack: fix object_id of exact sha1

2016-02-29 Thread Jeff King
On Mon, Feb 29, 2016 at 11:12:56PM -0300, Gabriel Souza Franco wrote: > Commit 58f2ed0 (remote-curl: pass ref SHA-1 to fetch-pack as well, > 2013-12-05) added support for specifying a SHA-1 as well as a ref name. > Add support for specifying just a SHA-1 and set the ref name to the same > value in

[PATCH v3] fetch-pack: fix object_id of exact sha1

2016-02-29 Thread Gabriel Souza Franco
Commit 58f2ed0 (remote-curl: pass ref SHA-1 to fetch-pack as well, 2013-12-05) added support for specifying a SHA-1 as well as a ref name. Add support for specifying just a SHA-1 and set the ref name to the same value in this case. Signed-off-by: Gabriel Souza Franco --- I did keep the oid varia