Re: [PATCH v3] diff-highlight: do not split multibyte characters

2015-04-04 Thread Yi, EungJun
On Fri, Apr 3, 2015 at 10:24 AM, Jeff King wrote: > > EungJun, does this version meet your needs? > > -Peff Yes, this patch is enough to meet my needs because it works well on UTF-8, the only encoding I use. And this patch looks better than my one because it is smaller, doesn't depend on String::

Re: [PATCH v3] diff-highlight: do not split multibyte characters

2015-04-04 Thread Jeff King
On Fri, Apr 03, 2015 at 03:15:14PM -0700, Kyle J. McKay wrote: > When the input is UTF-8 and Perl is operating on bytes instead of > characters, a diff that changes one multibyte character to another > that shares an initial byte sequence will result in a broken diff > display as the common byte s

[PATCH v3] diff-highlight: do not split multibyte characters

2015-04-03 Thread Kyle J. McKay
When the input is UTF-8 and Perl is operating on bytes instead of characters, a diff that changes one multibyte character to another that shares an initial byte sequence will result in a broken diff display as the common byte sequence prefix will be separated from the rest of the bytes in the multi