Re: [PATCH v3] commit-tree: utilize parse-options api

2019-03-04 Thread Brandon Richardson
On Mon, Mar 4, 2019 at 7:18 AM Duy Nguyen wrote: > You probably should mention about the extra _() too (e.g. "while at > there, mark more strings for translation") just to be clear it's > intentional. Good call. Will update. > > +#include "parse-options.h" > > +#include "string-list.h" > > Every

Re: [PATCH v3] commit-tree: utilize parse-options api

2019-03-04 Thread Duy Nguyen
On Mon, Mar 4, 2019 at 3:02 AM Brandon Richardson wrote: > > Rather than parse options manually, which is both difficult to > read and error prone, parse options supplied to commit-tree > using the parse-options api. > > It was discovered that the --no-gpg-sign option was documented > but not impl

[PATCH v3] commit-tree: utilize parse-options api

2019-03-03 Thread Brandon Richardson
Rather than parse options manually, which is both difficult to read and error prone, parse options supplied to commit-tree using the parse-options api. It was discovered that the --no-gpg-sign option was documented but not implemented in commit 70ddbd7767 (commit-tree: add missing --gpg-sign flag,