Hi Martin,
On Sat, 19 Jan 2019 at 17:19, Martin Ågren wrote:
> > > Or, a bit simpler:
> > >
> > > oid=$(echo 10 | git commit-tree -S HEAD^{tree}) &&
> > > git tag tenth-signed "$oid"
> >
> > Just noticed your latest email. Do you prefer it this way?
>
> I think so, yeah. (But who knows what o
Hi Brandon,
On Sat, 19 Jan 2019 at 19:05, Brandon Richardson
wrote:
> > I looked into this test in a bit more detail, and it seems to be quite
> > hard to get right. Part of the reason is that `git commit-tree` requires
> > a bit more careful use than `git commit`, but part of it is that the
> >
Hi Martin,
> I looked into this test in a bit more detail, and it seems to be quite
> hard to get right. Part of the reason is that `git commit-tree` requires
> a bit more careful use than `git commit`, but part of it is that the
> tests that we already have for `git commit-tree [-S]` right before
On Sat, 19 Jan 2019 at 16:46, Martin Ågren wrote:
> # commit.gpgsign is still on but this must not be signed
> - git tag ninth-unsigned $(echo 9 | git commit-tree HEAD^{tree}) &&
> + echo 9 | git commit-tree HEAD^{tree} >oid &&
> + test_line_count = 1 oid &&
> + git
Hi Brandon,
Thanks for a v3.
On Sat, 19 Jan 2019 at 04:36, Brandon Richardson
wrote:
> - if (skip_prefix(arg, "-S", &sign_commit))
> + if(!strcmp(arg, "--gpg-sign")) {
(Same nit as Junio about the missing space after "if".)
> + sign_commit = "";
Ni
Add --gpg-sign option in commit-tree, which was documented, but not
implemented, in 55ca3f99ae. Add tests for the --gpg-sign option.
Signed-off-by: Brandon Richardson
---
Hi all,
Third and (hopefully) final version. Thanks again Martin for the helpful
comments.
---
builtin/commit-tree.c|
6 matches
Mail list logo
