Re: [PATCH v3] commit: add a commit.allowEmpty config variable

2018-11-04 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > I.e. you seemingly have no interest in using "git commit" to produce > empty commits, but are just trying to cherry-pick something and it's > failing because it (presumably, or am I missing something) cherry picks > an existing commit content ends up not changing

Re: [PATCH v3] commit: add a commit.allowEmpty config variable

2018-11-03 Thread Ævar Arnfjörð Bjarmason
On Sat, Nov 03 2018, tanushree27 wrote: > +commit.allowEmpty:: > + A boolean to specify whether empty commits are allowed with `git > + commit`. See linkgit:git-commit[1]. > + Defaults to false. > + Good. > + if (config_commit_allow_empty >= 0) /* if allowEmpty is allowed in

[PATCH v3] commit: add a commit.allowEmpty config variable

2018-11-03 Thread tanushree27
Add commit.allowEmpty configuration variable as a convenience for those who always prefer --allow-empty. Add tests to check the behavior introduced by this commit. This closes https://github.com/git-for-windows/git/issues/1854 Signed-off-by: tanushree27 --- Documentation/config.txt | 5 ++