Re: [PATCH v3] builtin/apply: handle parse_binary() failure

2016-04-01 Thread Christian Couder
On Fri, Apr 1, 2016 at 1:16 PM, Junio C Hamano wrote: > Christian Couder writes: >> >> It looks like this patch is not in pu. Maybe it has fallen through the >> cracks? > > Yup, it indeed was ignored (giving priority to work towards 2.8 > during the freeze) and then was forgotten. > > My comment

Re: [PATCH v3] builtin/apply: handle parse_binary() failure

2016-04-01 Thread Junio C Hamano
Christian Couder writes: > On Fri, Mar 18, 2016 at 1:30 PM, Christian Couder > wrote: >> In parse_binary() there is: >> >> forward = parse_binary_hunk(&buffer, &size, &status, &used); >> if (!forward && !status) >> /* there has to be one hunk (forward hunk) */ >>

Re: [PATCH v3] builtin/apply: handle parse_binary() failure

2016-03-31 Thread Christian Couder
On Fri, Mar 18, 2016 at 1:30 PM, Christian Couder wrote: > In parse_binary() there is: > > forward = parse_binary_hunk(&buffer, &size, &status, &used); > if (!forward && !status) > /* there has to be one hunk (forward hunk) */ > return error(_("unrec

[PATCH v3] builtin/apply: handle parse_binary() failure

2016-03-19 Thread Christian Couder
In parse_binary() there is: forward = parse_binary_hunk(&buffer, &size, &status, &used); if (!forward && !status) /* there has to be one hunk (forward hunk) */ return error(_("unrecognized binary patch at line %d"), linenr-1); so parse_binary() can