Re: [PATCH v3] Teach git to change to a given directory using -C option

2013-09-09 Thread Eric Sunshine
On Mon, Sep 9, 2013 at 12:32 PM, Junio C Hamano wrote: >> + echo "initial in dir1/dir2" >expected && >> + git -C dir1/dir2 commit -m "initial in dir1/dir2" && > > to reduce possibilities of breaking this test in the future due to > typos (e.g. somebody may want to say "initial commit in di

Re: [PATCH v3] Teach git to change to a given directory using -C option

2013-09-09 Thread Junio C Hamano
Eric Sunshine writes: > On Mon, Sep 9, 2013 at 12:32 PM, Junio C Hamano wrote: >> Nazri Ramliy writes: >> >>> Subject: git: run in a directory given with -C option >>> >>> +-C :: >>> + Run as if git was started in '' instead of the current working >>> + directory. When multiple '-C' op

Re: [PATCH v3] Teach git to change to a given directory using -C option

2013-09-09 Thread Eric Sunshine
On Mon, Sep 9, 2013 at 12:32 PM, Junio C Hamano wrote: > Nazri Ramliy writes: > >> Subject: git: run in a directory given with -C option >> >> +-C :: >> + Run as if git was started in '' instead of the current working >> + directory. When multiple '-C' options are given, each subsequent

Re: [PATCH v3] Teach git to change to a given directory using -C option

2013-09-09 Thread Junio C Hamano
Nazri Ramliy writes: > Subject: git: run in a directory given with -C option > > This is similar in spirit to to "make -C dir ..." and "tar -C dir ...". The doubled-"to to" which I locally fixed when I queued the last one (together with other rewording to make it more agreeable and easier to rea

Re: [PATCH v3] Teach git to change to a given directory using -C option

2013-09-09 Thread Nazri Ramliy
On Mon, Sep 09, 2013 at 01:01:33AM -0400, Eric Sunshine wrote: > On Sun, Sep 8, 2013 at 9:49 PM, Nazri Ramliy wrote: > Thanks for the reference. I did read that thread earlier. It doesn't > really answer my question, but perhaps it's not terribly important > since the interaction is documented. I

Re: [PATCH v3] Teach git to change to a given directory using -C option

2013-09-08 Thread Eric Sunshine
On Sun, Sep 8, 2013 at 9:49 PM, Nazri Ramliy wrote: > On Sun, Sep 8, 2013 at 6:32 PM, Eric Sunshine wrote: >>> +This option affects options that expect path name like --git-dir and >>> +--work-tree in that their interpretations of the path names would be >>> +made relative to the working director

Re: [PATCH v3] Teach git to change to a given directory using -C option

2013-09-08 Thread Nazri Ramliy
On Sun, Sep 8, 2013 at 6:32 PM, Eric Sunshine wrote: > For consistency with existing formatting in git.txt, you may want to > squash in the following fixes (sans gmail whitespace damage): > > --- >8 --- [ diff snipped ] > --- >8 --- Thanks. I'll submit a reroll later. >> +This option affects opt

Re: [PATCH v3] Teach git to change to a given directory using -C option

2013-09-08 Thread Eric Sunshine
On Wed, Sep 4, 2013 at 8:20 AM, Nazri Ramliy wrote: > Subject: git: run in a directory given with -C option > > This is similar in spirit to to "make -C dir ..." and "tar -C dir ...". > --- > diff --git a/Documentation/git.txt b/Documentation/git.txt > index 83edf30..ae049da 100644 > --- a/Documen

Re: [PATCH v3] Teach git to change to a given directory using -C option

2013-09-04 Thread Nazri Ramliy
On Wed, Sep 04, 2013 at 02:36:47PM +0800, Nazri Ramliy wrote: > On Wed, Sep 4, 2013 at 6:46 AM, Junio C Hamano wrote: > > Does the above format correctly without the usual "second and > > subsequent paragraphs are not indented, but has '+' in place of > > a blank line"? > > No it doesn't. I'll fi

Re: [PATCH v3] Teach git to change to a given directory using -C option

2013-09-03 Thread Eric Sunshine
On Wed, Sep 4, 2013 at 2:36 AM, Nazri Ramliy wrote: > On Wed, Sep 4, 2013 at 6:46 AM, Junio C Hamano wrote: >> I do not care too deeply either way, but I am curious if there was a >> reason why you changed the earlier to ? Somehow, >> when we _know_ a path has to be a directory, I find it easie

Re: [PATCH v3] Teach git to change to a given directory using -C option

2013-09-03 Thread Nazri Ramliy
On Wed, Sep 4, 2013 at 6:46 AM, Junio C Hamano wrote: > I do not care too deeply either way, but I am curious if there was a > reason why you changed the earlier to ? Somehow, > when we _know_ a path has to be a directory, I find it easier on the > readers to spell that out, instead of saying "t

Re: [PATCH v3] Teach git to change to a given directory using -C option

2013-09-03 Thread Eric Sunshine
On Tue, Sep 3, 2013 at 6:46 PM, Junio C Hamano wrote: > Nazri Ramliy writes: > >> -- >8 -- >> diff --git a/Documentation/git.txt b/Documentation/git.txt >> index 83edf30..6105cb0 100644 >> --- a/Documentation/git.txt >> +++ b/Documentation/git.txt >> @@ -9,7 +9,7 @@ git - the stupid content track

Re: [PATCH v3] Teach git to change to a given directory using -C option

2013-09-03 Thread Junio C Hamano
Nazri Ramliy writes: > -- >8 -- > Subject: [PATCH] Teach git to change to a given directory using -C option > > This is similar in spirit to to "make -C dir ..." and "tar -C dir ...". > > Currently it takes more effort (keypresses) to invoke git command in a > different directory than the current

[PATCH v3] Teach git to change to a given directory using -C option

2013-09-03 Thread Nazri Ramliy
On Tue, Sep 3, 2013 at 3:42 PM, Eric Sunshine wrote: > No wish to bike-shed, however, I find "effective directory" somewhat > difficult to digest due to its jargony feel. It also seems ambiguous > (to me) since "previous effective directory" may mean "directory when > git was run" or "directory se