Re: [PATCH v3] [submodule] Add --depth to submodule update/add

2013-07-02 Thread Junio C Hamano
Fredrik Gustafsson writes: > git clone dies with the error "too many arguments". This was solved with > changing > depth=$5 > to > depth="$5" > > which I don't understand since variable assignment doesn't expand $5 and > therefore > "" should not be needed, AFAIK. Any comments on this? A red h

Re: [PATCH v3] [submodule] Add --depth to submodule update/add

2013-07-02 Thread Jens Lehmann
Sending again because the first one bounced. Am 02.07.2013 03:39, schrieb Fredrik Gustafsson: > When a submodule is clone, clone it width the --depth flag. This is useful > when the submodule(s) are huge and you're not really interested in anything > but the latest commit. > > Tests are added and

Re: [PATCH v3] [submodule] Add --depth to submodule update/add

2013-07-02 Thread Andreas Schwab
Fredrik Gustafsson writes: > This was actually a bit tricky. When I changed > git clone $depth > to > git clone "$depth" > > git clone dies with the error "too many arguments". ... when $depth is empty. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942

[PATCH v3] [submodule] Add --depth to submodule update/add

2013-07-01 Thread Fredrik Gustafsson
When a submodule is clone, clone it width the --depth flag. This is useful when the submodule(s) are huge and you're not really interested in anything but the latest commit. Tests are added and to make --depth work the path for test "setup a submodule tree" had to be modified. Also did some indent