Re: [PATCH v2 6/7] Fix tests under GETTEXT_POISON on git-remote

2012-08-27 Thread Junio C Hamano
Jiang Xin writes: >> This couldn't have possibly passed with the trailing &&, or am I >> missing something? There is already "add another remote" before >> this test that adds "second" remote. Is this test about "add >> yet another remote", or is it checking the result of adding "second" >> tha

Re: [PATCH v2 6/7] Fix tests under GETTEXT_POISON on git-remote

2012-08-27 Thread Jiang Xin
2012/8/28 Junio C Hamano : > Jiang Xin writes: > >> Use i18n-specific test functions in test scripts for git-remote. >> This issue was was introduced in v1.7.10-233-gbb16d5: >> >> bb16d5 i18n: remote: mark strings for translation >> >> and been broken under GETTEXT_POISON=YesPlease since. >> >

Re: [PATCH v2 6/7] Fix tests under GETTEXT_POISON on git-remote

2012-08-27 Thread Junio C Hamano
Jiang Xin writes: > Use i18n-specific test functions in test scripts for git-remote. > This issue was was introduced in v1.7.10-233-gbb16d5: > > bb16d5 i18n: remote: mark strings for translation > > and been broken under GETTEXT_POISON=YesPlease since. > > Signed-off-by: Jiang Xin > Signed-o

[PATCH v2 6/7] Fix tests under GETTEXT_POISON on git-remote

2012-08-26 Thread Jiang Xin
Use i18n-specific test functions in test scripts for git-remote. This issue was was introduced in v1.7.10-233-gbb16d5: bb16d5 i18n: remote: mark strings for translation and been broken under GETTEXT_POISON=YesPlease since. Signed-off-by: Jiang Xin Signed-off-by: Nguyễn Thái Ngọc Duy --- t