Re: [PATCH v2 5/9] completion: refactor diff_index wrappers

2013-04-27 Thread Junio C Hamano
Felipe Contreras writes: > At the end of the day what we really need is to find out the files that > have been staged, or modified, because those files are the ones that > make sense to pass as arguments to 'git commit'. > > We need diff-index to find those out, since 'git ls-files' doesn't do >

[PATCH v2 5/9] completion: refactor diff_index wrappers

2013-04-27 Thread Felipe Contreras
At the end of the day what we really need is to find out the files that have been staged, or modified, because those files are the ones that make sense to pass as arguments to 'git commit'. We need diff-index to find those out, since 'git ls-files' doesn't do that. But we don't need wrappers and