Re: [PATCH v2 5/7] add-interactive.c: implement show-help command

2019-01-18 Thread Johannes Schindelin
Hi Phillip, On Fri, 18 Jan 2019, Phillip Wood wrote: > On 18/01/2019 12:19, Slavica Đukić wrote: > > > > On 18-Jan-19 12:20 PM, Phillip Wood wrote: > > > > > > I think this round is looking good I've got a couple of comments > > > about the translation of the help text but everything else looks

Re: [PATCH v2 5/7] add-interactive.c: implement show-help command

2019-01-18 Thread Phillip Wood
Hi Slavica On 18/01/2019 12:19, Slavica Đukić wrote: Hi Phillip, On 18-Jan-19 12:20 PM, Phillip Wood wrote: Hi Slavica I think this round is looking good I've got a couple of comments about the translation of the help text but everything else looks fine to me now. In future when you're postin

Re: [PATCH v2 5/7] add-interactive.c: implement show-help command

2019-01-18 Thread Slavica Djukic
Hi Phillip, On 18-Jan-19 12:20 PM, Phillip Wood wrote: Hi Slavica I think this round is looking good I've got a couple of comments about the translation of the help text but everything else looks fine to me now. In future when you're posting a new version it's helpful CC the people who commente

Re: [PATCH v2 5/7] add-interactive.c: implement show-help command

2019-01-18 Thread Phillip Wood
Hi Slavica I think this round is looking good I've got a couple of comments about the translation of the help text but everything else looks fine to me now. In future when you're posting a new version it's helpful CC the people who commented on the previous version(s). On 18/01/2019 07:47, Slavic

[PATCH v2 5/7] add-interactive.c: implement show-help command

2019-01-17 Thread Slavica Djukic via GitGitGadget
From: Slavica Djukic Implement show-help command in add-interactive.c and use it in builtin add--helper.c. Use command name "show-help" instead of "help": add--helper is builtin, hence add--helper --help would be intercepted by handle_builtin and re-routed to the help command, without ever calli