Re: [PATCH v2 4/6] Refactor mechanics of testing in a sub test-lib

2012-09-19 Thread Adam Spiers
On Wed, Sep 19, 2012 at 03:37:08PM -0400, Jeff King wrote: > Looking at it again, it is actually quite subtle what is going on. We > wrap the outer test_expect_* calls in double-quotes so that the inner > ones can use single-quotes easily. But that means that technically the > contents of the here-

Re: [PATCH v2 4/6] Refactor mechanics of testing in a sub test-lib

2012-09-19 Thread Jeff King
On Wed, Sep 19, 2012 at 07:44:06PM +0100, Adam Spiers wrote: > > Is it just that you are dropping the '\' in all of the here-docs because > > they are not needed? > > Hmm, I think I previously misunderstood the point of the \\ due to > never seeing that syntax before (since my Perl background tau

Re: [PATCH v2 4/6] Refactor mechanics of testing in a sub test-lib

2012-09-19 Thread Adam Spiers
On Wed, Sep 19, 2012 at 01:56:55PM -0400, Jeff King wrote: > On Wed, Sep 19, 2012 at 06:15:13PM +0100, Adam Spiers wrote: > > > This will allow us to test the test framework more thoroughly > > without disrupting the top-level test metrics. > > I see this is prep for the next patch, and the parts

Re: [PATCH v2 4/6] Refactor mechanics of testing in a sub test-lib

2012-09-19 Thread Jeff King
On Wed, Sep 19, 2012 at 06:15:13PM +0100, Adam Spiers wrote: > This will allow us to test the test framework more thoroughly > without disrupting the top-level test metrics. I see this is prep for the next patch, and the parts pulling out the test-runs into functions make sense. But this hunk con

[PATCH v2 4/6] Refactor mechanics of testing in a sub test-lib

2012-09-19 Thread Adam Spiers
This will allow us to test the test framework more thoroughly without disrupting the top-level test metrics. Signed-off-by: Adam Spiers --- t/t-basic.sh | 44 +++- 1 file changed, 27 insertions(+), 17 deletions(-) diff --git a/t/t-basic.sh b/t/t00