Re: [PATCH v2 4/5] Makefile: use the sha1collisiondetection submodule by default

2017-12-08 Thread Jeff King
On Fri, Dec 08, 2017 at 03:21:23PM -0800, Junio C Hamano wrote: > Junio C Hamano writes: > > > That endgame allows us not force people to grab an essential part of > > the codebase as an external dependency from another place, which > > feels quite bad, especially when their primary interest is

Re: [PATCH v2 4/5] Makefile: use the sha1collisiondetection submodule by default

2017-12-08 Thread Ævar Arnfjörð Bjarmason
On Fri, Dec 08 2017, Junio C. Hamano jotted: > Ævar Arnfjörð Bjarmason writes: > >> Instead the Makefile will emit an error if the contents of the >> submodule aren't checked out (line-wrapped. GNU make emits this all on >> one line): >> >> Makefile:1031: *** The sha1collisiondetection subm

Re: [PATCH v2 4/5] Makefile: use the sha1collisiondetection submodule by default

2017-12-08 Thread Junio C Hamano
Junio C Hamano writes: > That endgame allows us not force people to grab an essential part of > the codebase as an external dependency from another place, which > feels quite bad, especially when their primary interest is not in > dogfooding submodule but in building a working version of Git. > >

Re: [PATCH v2 4/5] Makefile: use the sha1collisiondetection submodule by default

2017-12-08 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Instead the Makefile will emit an error if the contents of the > submodule aren't checked out (line-wrapped. GNU make emits this all on > one line): > > Makefile:1031: *** The sha1collisiondetection submodule is not > checked out. Please make it availabl

[PATCH v2 4/5] Makefile: use the sha1collisiondetection submodule by default

2017-12-08 Thread Ævar Arnfjörð Bjarmason
Change the build process so that instead of needing to supply DC_SHA1_SUBMODULE=YesPlease to use the sha1collisiondetection submodule instead of the copy of the same code shipped in the sha1dc directory, it uses the submodule by default unless NO_DC_SHA1_SUBMODULE=NoThanks is supplied. This revers