Re: [PATCH v2 4/5] Integrate wildmatch to git

2012-09-17 Thread Junio C Hamano
Nguyen Thai Ngoc Duy writes: > On Sun, Sep 16, 2012 at 10:54:57PM -0700, Junio C Hamano wrote: >> Yeah, popt.h it is. It is a bit distasteful that we have a build >> dependency only to build test-* helper on something that we do not >> even have runtime dependency on. > > Perhaps this squash-in?

Re: [PATCH v2 4/5] Integrate wildmatch to git

2012-09-17 Thread Nguyen Thai Ngoc Duy
On Sun, Sep 16, 2012 at 10:54:57PM -0700, Junio C Hamano wrote: > Yeah, popt.h it is. It is a bit distasteful that we have a build > dependency only to build test-* helper on something that we do not > even have runtime dependency on. Perhaps this squash-in? It kills libpopt and removes the "#inc

Re: [PATCH v2 4/5] Integrate wildmatch to git

2012-09-16 Thread Nguyen Thai Ngoc Duy
On Mon, Sep 17, 2012 at 12:54 PM, Junio C Hamano wrote: > Yeah, popt.h it is. It is a bit distasteful that we have a build > dependency only to build test-* helper on something that we do not > even have runtime dependency on. Yep. I don't know how popular libpopt is. But if it's undesired, we c

Re: [PATCH v2 4/5] Integrate wildmatch to git

2012-09-16 Thread Junio C Hamano
Junio C Hamano writes: > Am I missing some includes? > > test-wildmatch.c:50: error: array type has incomplete element type > test-wildmatch.c:52: error: 'POPT_ARG_NONE' undeclared here (not in a > function) > test-wildmatch.c:53: error: 'POPT_ARG_STRING' undeclared here (not in a > function) >

Re: [PATCH v2 4/5] Integrate wildmatch to git

2012-09-16 Thread Junio C Hamano
Am I missing some includes? test-wildmatch.c:50: error: array type has incomplete element type test-wildmatch.c:52: error: 'POPT_ARG_NONE' undeclared here (not in a function) test-wildmatch.c:53: error: 'POPT_ARG_STRING' undeclared here (not in a function) test-wildmatch.c:54: error: 'POPT_ARG_IN

[PATCH v2 4/5] Integrate wildmatch to git

2012-09-16 Thread Nguyễn Thái Ngọc Duy
This makes wildmatch.c part of libgit.a and builds test-wildmatch Signed-off-by: Nguyễn Thái Ngọc Duy --- .gitignore | 1 + Makefile | 6 ++ t/t3070-wildmatch.sh | 27 +++ test-wildmatch.c | 8 +++- wildmatch.c | 8 +++-