Re: [PATCH v2 3/5] commit-graph: create new version flags

2019-04-25 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > It doesn't make sense to start saying "version A" here when we make it > to version 10, however unlikely that is :) ;-)

Re: [PATCH v2 3/5] commit-graph: create new version flags

2019-04-25 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 24 2019, Derrick Stolee via GitGitGadget wrote: > - hash_version = *(unsigned char*)(data + 5); > - if (hash_version != oid_version()) { > - error(_("commit-graph hash version %X does not match version > %X"), > - hash_version, oid_version()); >

Re: [PATCH v2 3/5] commit-graph: create new version flags

2019-04-25 Thread Derrick Stolee
On 4/25/2019 1:29 AM, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" writes: > >> +int version = 0; >> ... >> +if (flags & COMMIT_GRAPH_VERSION_1) >> +version = 1; >> +if (!version) >> +version = 1; >> +if (version != 1) { >> +error(_

Re: [PATCH v2 3/5] commit-graph: create new version flags

2019-04-24 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > + int version = 0; > ... > + if (flags & COMMIT_GRAPH_VERSION_1) > + version = 1; > + if (!version) > + version = 1; > + if (version != 1) { > + error(_("unsupported commit-graph version %d"), > +

[PATCH v2 3/5] commit-graph: create new version flags

2019-04-24 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee In anticipation of a new commit-graph file format version, create a flag for the write_commit_graph() and write_commit_graph_reachable() methods to take a version number. When there is no specified version, the implementation selects a default value. Currently, the only vali