Re: [PATCH v2 3/3] t/lib-httpd: avoid occasional failures when checking access.log

On Wed, Jul 11, 2018 at 07:26:19PM +0200, SZEDER Gábor wrote: > > But it is really "make sure that a failed test here does not prevent us > > from doing this cleanup". So the original really should have just > > dropped that comment and added a test_when_finished. Bumping it into a > > separate te

Re: [PATCH v2 3/3] t/lib-httpd: avoid occasional failures when checking access.log

On Wed, Jul 11, 2018 at 4:57 PM Jeff King wrote: > > On Wed, Jul 11, 2018 at 02:56:47PM +0200, SZEDER Gábor wrote: > > > +# Requires one argument: the name of a file containing the expected > > stripped > > +# access log entries. > > +check_access_log() { > > + sort "$1" >"$1".sorted && > > +

Re: [PATCH v2 3/3] t/lib-httpd: avoid occasional failures when checking access.log

On Wed, Jul 11, 2018 at 02:56:47PM +0200, SZEDER Gábor wrote: > +# Requires one argument: the name of a file containing the expected stripped > +# access log entries. > +check_access_log() { > + sort "$1" >"$1".sorted && > + strip_access_log >access.log.stripped && > + sort access.log.

[PATCH v2 3/3] t/lib-httpd: avoid occasional failures when checking access.log

The last test of 't5561-http-backend.sh', 'server request log matches test results' may fail occasionally, because the order of entries in Apache's access log doesn't match the order of requests sent in the previous tests, although all the right requests are there. I saw it fail on Travis CI five