Re: [PATCH v2 3/3] http-backend: spool ref negotiation requests to buffer

2015-05-25 Thread Junio C Hamano
Jeff King writes: > Whoops, yeah, it was just for debugging. I missed that one when sending > out the patch. > > Junio, the squashable patch is below (on jk/http-backend-deadlock-2.2), > and it looks like nothing has hit "next" yet. But you did do some > up-merging of the topic. Let me know if yo

Re: [PATCH v2 3/3] http-backend: spool ref negotiation requests to buffer

2015-05-25 Thread Jeff King
On Mon, May 25, 2015 at 10:07:50PM -0400, Konstantin Ryabitsev wrote: > On 20 May 2015 at 03:37, Jeff King wrote: > > + /* partial read from read_in_full means we hit EOF */ > > + len += cnt; > > + if (len < alloc) { > > + *out = buf

Re: [PATCH v2 3/3] http-backend: spool ref negotiation requests to buffer

2015-05-25 Thread Konstantin Ryabitsev
On 20 May 2015 at 03:37, Jeff King wrote: > + /* partial read from read_in_full means we hit EOF */ > + len += cnt; > + if (len < alloc) { > + *out = buf; > + warning("request size was %lu", (unsigned long)len);

[PATCH v2 3/3] http-backend: spool ref negotiation requests to buffer

2015-05-20 Thread Jeff King
When http-backend spawns "upload-pack" to do ref negotiation, it streams the http request body to upload-pack, who then streams the http response back to the client as it reads. In theory, git can go full-duplex; the client can consume our response while it is still sending the request. In practic